Age | Commit message (Collapse) | Author |
|
There were many more places where I had hardcoded values, but
should have used strlen() or sizeof(). I have gone through
tcoin.cpp and pcoin.cpp, found those, and fixed them.
Hopefully, this is all of them.
|
|
In user_has_initialised(..), the path lengths were hardcoded.
This has now been changed to being calculated via sizeof().
In get_file_value and add_file_value, strlen() was used. This has
also been replaced with sizeof().
|
|
Merging changes from the master branch because I forgot to do git pull
|
|
Added comment to tcoin.cpp to send the actual error message to
stderr when running exit_program(err_no).
|
|
The scrypt binary file's permissions were modified on tilde.town.
|
|
I had updated the 'ntcoin' script but had forgotten to change README.md.
|
|
Refactored the send function in tcoin and pcoin, and in the process,
fixed a bug in pcoin's silentsend function.
|
|
Remove outdated comment
|
|
The comment referred to using || instead of &&, despite the fact that the code now uses &&.
|
|
This was done so that the date generation changes for OpenBSD and tilde.institute-type systems will apply.
|
|
On OpenBSD, the equivalent of %_d is %e. This is fixed for OpenBSD/tilde.institute type systems now.
|
|
I was planning to make a change that I did not adequately reverse, so I have reversed it fully now.
The change I was planning to make was to remove references to login@tilde.town on systems that were
not tilde.town, but I decided against that change eventually (but didn't reverse it fully).
|
|
1. Custom host name now possible in tcoin --help
2. Changes to ntcoin and ntcoin_openbsd_tildeinstitute to fix a bug in -d/--def.
3. Changes to ntcoin and ntcoin_openbsd_tildeinstitute to check for the correct number of arguments.
4. Changes to ntcoin and ntcoin_openbsd_tildeinstitute to include the host name as a preprocessor constant.
|
|
1. Removed unneeded WHOAMI_PATH preprocessor constant from pcoin.cpp.
2. Updated WHOAMI_PATH for tilde.institute to use "id -ru" to get the real uid on OpenBSD (/usr/bin/whoami doesn't get the real username on OpenBSD).
|
|
Thanks to gbmor, I was able to replace base64 (fourmilab version) (which outputs \r\n and thus interferes with tr -d '\n') with gbase64 (the GNU coreutils version) which only outputs '\n'.
|
|
Removed references to realpath.c, which is no longer included. Added a few more requirements to the README.md for "ntcoin" to run.
|
|
I have created a version of ntcoin that works on tilde.institute's OpenBSD system. I suppose I have to make ntcoin better by using something like make and more POSIX-compliant.
|
|
It wasn't useful.
|
|
|
|
Updated README.md to include some dependencies for running "ntcoin".
|
|
Changed first line of description to match Github's description.
|
|
I forgot that base_amount held the number of centitildecoins, and that I had to use cout_formatted_amount() to actually send to stdout the number of tildecoins (with decimal places).
|
|
I forgot to type "help(" and had just typed "void long long int base_amount)".
|
|
Brought to my attention by ~mastergeek on tilde.team, the tcoin help incorrectly said that the number of tildecoins a user started with was 1000. It was actually the current base amount (unaltered by other sources like minercoin, tildebot or daily-adventure). Now, the help shows the right amount of starting coins.
|
|
Thanks to ~lickthecheese on tilde.town, tilde.team and other tildeboxes, I was informed of this typo: 'creata' -> 'create'
|
|
And I don't know how to clean my commits after having pushed
them to remote origin/master. Maybe a Git stash and hard reset?
|
|
TCOIN_MSG_LENGTH_LIMIT
I made a switch from TCOIN_MSG_LENGTH to TCOIN_MSG_LENGTH_LIMIT for the symbolic constant
representing the maximum number of characters of a transaction message. I changed all instances
of the symbolic constant to this new name in tcoin.cpp, but forgot to do it in one instance in
pcoin.cpp. This goes on to show that I need to develop tests for tcoin and pcoin, as well as
start using getopt from util-linux for proper options handling.
|
|
After having received a 10000-character transaction message from ~jan6@envs.net,
I finally came around to implementing character limits on transaction messages.
Previously, I was of the opinion that one should be able to send a movie as a
transaction message if one so wished.
I took inspiration for an appropriate character limit from Australia's NPP (New
Payments Platform), which has a 280-character limit on transaction messages. I
strongly suspect this limit came from Twitter's analysis of tweets in different
languages and Twitter research that concluded that a 280-character tweet was the
appropriate length of tweet. A transaction message is supposedly like a tweet with
some money sent along with it.
|
|
I don't know how I missed this, because I remember coming across this deficiency before.
I had missed a case, where silentsend is requested but with a message. Previously, it would
fail without any message to stdout or stderr (only a return code).
Now, silentsend with a message works even on pcoin.cpp (tcoin.cpp already had this change).
|
|
I made a mistake. I should have done this before making my commits.
That's the only reason why this merge is necessary.
|
|
constants
I had forgotten to handle the fatal errors and take the error numbers out into symbolic constants. I have now done that in tcoin.cpp and pcoin.cpp
|
|
I had forgotten to change \u23CE to <new-line> and introduce a check for <vertical-tab> in many many places
in tcoin.cpp and pcoin.cpp. I should probably put these things in some kind of function so I don't repeat myself.
I'll probably do that in a future commit.
|
|
This doesn't change functionality. It is simply a refactor that separates error codes out into symbolic constants in tcoin.cpp and pcoin.cpp.
|
|
<vertical-tab>
Newlines and vertical tabs in messages are replaced with <new-line> and <vertical-tab> to prevent transaction spoofing inside a message.
|
|
|
|
ntcoin's help said "tcoin subdirectories" for the first path argument. It was not clear whether this argument should include "/tcoin" or not. Now, this has been made clearer so that it means the 'tcoin' directory itself.
|
|
Fixed a typographical error in ntcoin (there was an extra ').
|
|
To ensure that builds are verifiable, tcoin_defs.cpp and pcoin_defs.cpp are copied from tcoin/bin to ~/bin (i.e., to the same directory as the 'tcoin' and 'pcoin' executables)
|
|
Just added a period/fullstop to the message in the show_balances() function.
|
|
Well, that was embarrassing. My nano tcoin.cpp and pcoin.cpp swap files got uploaded!
|
|
The title is confusing, sorry. "No messages found" is shown in tcoin and pcoin when no messages are found (and this no-message message has one newline above and one newline below it instead of two newlines above it as before).
|
|
Minor correction to README.md, where the phrase "Program users" was replaced with "Program accounts" in the heading.
|
|
Updated README.md to provide instructions to get started easily, including program-account creation (which was not well-documented previously).
|
|
|
|
Just a minor aesthetic fix so that there is even newline gaps between statements when running 'tcoin init'.
|
|
Just a minor aesthetic fix so that there is even newline gaps between statements when running 'tcoin init'.
|
|
A small error was present in ntcoin, where a chmod on a file that may not exist was blocking the execution of future commands due to failing. Now, the command is always set to succeed.
|
|
Fixed a bug in ntcoin where the symlinks from tcoin/bin/compile_tcoin and tcoin/bin/edit_tcoin to ~/bin/compile_tcoin and ~/bin/edit_tcoin are made properly. The previous command did something else.
|
|
ntcoin would accept no number of basecoins <n>. Now, there is a check added near the beginning for <n> existing and being a non-negative integer.
|
|
ntcoin had an error in the way it created compile_pcoin. compile_pcoin had a missing \ at the end of the line (for line continuation). This bug has now been fixed.
|