summary refs log tree commit diff
diff options
context:
space:
mode:
authorlogin2019-11-15 01:45:07 +0000
committerlogin2019-11-15 03:27:06 +0000
commit55bfe1fb8992c450d97c97a109563a8b49be7744 (patch)
treea5f20b68b29d6b63f5d5010ec4351e2bde181cdc
parent1e356ac01725f485c509a3326e6730918a8ece90 (diff)
Improving the messaging around sending transaction messages
Several changes were made that were difficult to separate into separate commits. Since features are directly committed to master, there are no feature branches.

The high-level list of changes is as follows:
1. Fixed a bug in pcoin where using "pcoin send -s" for silentsend would forget to add the transaction message that provides a record of who transferred how much and when, even if there is no custom message appended (send_message(.) was not called).
2. Improved the help text to make it clear that sending messages could be done using silentsend too.
3. In several cases in tcoin and pcoin, certain ways of doing a silentsend would still send with verbose output because, by mistake, the option passed to send_message(.) was not changed from "verbose" to "silent".
4. In pcoin, there was the case of 6 arguments missing, where one does pcoin send -s <user> <amount> <message>. This case was handled in tcoin but not pcoin. Now, it is handled in pcoin too.
5. Now, when a custom message is sent in tcoin or pcoin, an additional text confirming the successful sending of the custom message as distinct from the one confirming the sending of the coins is displayed to the user.
-rw-r--r--pcoin.cpp0
-rw-r--r--tcoin.cpp0
2 files changed, 0 insertions, 0 deletions
diff --git a/pcoin.cpp b/pcoin.cpp
index 9031cb3..fb85cdd 100644
--- a/pcoin.cpp
+++ b/pcoin.cpp
diff --git a/tcoin.cpp b/tcoin.cpp
index 932b84f..4556ca3 100644
--- a/tcoin.cpp
+++ b/tcoin.cpp